SapMachine #2250: Add adjustments to heap dumps for the buildpack#2251
Conversation
|
Hello @schmelter-sap, this pull request fulfills all formal requirements. |
|
Couple of minor adjustments might be needed in globals.hpp |
|
Hello @schmelter-sap, this pull request fulfills all formal requirements. |
|
Hello @schmelter-sap, this pull request fulfills all formal requirements. |
|
Hello @schmelter-sap, this pull request fulfills all formal requirements. |
|
Hello @schmelter-sap, this pull request fulfills all formal requirements. |
|
Hello @schmelter-sap, this pull request fulfills all formal requirements. |
dbriemann
left a comment
There was a problem hiding this comment.
One small change needed.
|
Hello @schmelter-sap, this pull request fulfills all formal requirements. |
RealCLanger
left a comment
There was a problem hiding this comment.
Found one minor spelling nit.
And a more general question: Don't you think this could be something to contribute to the OpenJDK? Like "space efficient generation of heap dumps" or such?
|
Hello @schmelter-sap, this pull request fulfills all formal requirements. |
This change adds features to the heap dump for the cf buildpack to be able to store heap dumps for customers in the object store. It includes the following features:
fixes #2250